Update segments module to handle incoming changes from gwpy DataQualityDict updates#417
Draft
eagoetz wants to merge 1 commit intogwpy:masterfrom
Draft
Update segments module to handle incoming changes from gwpy DataQualityDict updates#417eagoetz wants to merge 1 commit intogwpy:masterfrom
eagoetz wants to merge 1 commit intogwpy:masterfrom
Conversation
eagoetz
force-pushed
the
rename-url-host
branch
3 times, most recently
from
6380af5 to
332d620
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 49.25% 49.24% -0.01%
==========================================
Files 60 60
Lines 8804 8798 -6
==========================================
- Hits 4336 4332 -4
+ Misses 4468 4466 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eagoetz
force-pushed
the
rename-url-host
branch
from
332d620 to
476b064
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
segmentsmodule to handle changes to thegwpy.DataQualityDictAPI changingurlkeyword tohost.Also some minor clean up of the code and setting new version pins.
This PR is draft pending tests